Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ten Gateway Caching #1779

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Ten Gateway Caching #1779

merged 5 commits into from
Feb 16, 2024

Conversation

zkokelj
Copy link
Contributor

@zkokelj zkokelj commented Feb 7, 2024

Why this change is needed

We want to cache some results on the Ten Gateway and not forward all the requests to the Ten Node

What changes were made as part of this PR

  • New cache added (ristretto.Cache is used)
  • Simple interface that allows us to simply change the cache library / use different type of caching in the future
  • Per method TTL and logic to determine if methods are cacheable and for how long
  • Tests

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

@zkokelj zkokelj force-pushed the ziga/gateway_caching branch 2 times, most recently from 5f79e9c to 99a7a96 Compare February 9, 2024 10:36
@zkokelj zkokelj marked this pull request as ready for review February 9, 2024 11:22
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkokelj zkokelj force-pushed the ziga/gateway_caching branch from 49eb6ee to 1ba576f Compare February 16, 2024 09:43
@zkokelj zkokelj merged commit 5b5e7d9 into main Feb 16, 2024
2 checks passed
@zkokelj zkokelj deleted the ziga/gateway_caching branch February 16, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants